Skip to content

Fix bug while you use new BitcoinJS-lib and old method invokes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmitrykuzmenkov wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug while you use new BitcoinJS-lib and old method invokes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47a43cf
Fix issue when you need to use multiple inputs but code has code to w…
dmitrykuzmenkov Oct 8, 2017
6faaf27
Fix wrong address when you pass financeChangeAddress
dmitrykuzmenkov Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ ColoredCoinsBuilder.prototype._addInputsForSendTransaction = function (txb, args
if (coloredChange) {
coloredOutputIndexes.push(txb.tx.outs.length)
}
txb.addOutput(Array.isArray(args.from) ? args.from[0] : args.from, lastOutputValue)
txb.addOutput(changeAddress, lastOutputValue)
debug('success')
return { txHex: txb.tx.toHex(), metadataSha1: args.torrentHash, multisigOutputs: reedemScripts, coloredOutputIndexes: _.uniqBy(coloredOutputIndexes) }
}
Expand Down
2 changes: 1 addition & 1 deletion modules/findBestMatchByNeededAssets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ var findBestMatchByNeededAssets = function (utxos, assetList, key, txb, inputval
debug('adding input')
var inputIndex = txb.tx.ins.length
if (!txb.tx.ins.some(function (txutxo, i) {
if (txutxo.index === utxo.index && bitcoinjs.bufferutils.reverse(txutxo.hash).toString('hex') === utxo.txid) {
if (txutxo.index === utxo.index && txutxo.hash.toString('hex').split('').reverse().join('') === utxo.txid) {
debug('more assets in same utxo')
inputIndex = i
return true
Expand Down