-
Notifications
You must be signed in to change notification settings - Fork 7
feat(medcat): CU-869bhm1zy Improve plugins #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7eb6e32
CU-869bhm1zy: Gather data from plugins regarding the components they …
mart-r 78d6057
CU-869bhm1zy: Add missing plugin registry
mart-r e83d5d0
CU-869bhm1zy: Separate version calculations to avoid circular imports
mart-r 24fedcd
CU-869bhm1zy: Add a few tests for plugin loader
mart-r 2998f85
CU-869bhm1zy: Add missing init file for test package
mart-r 3a17523
CU-869bhm1zy: Add initial model card output for plugin and pipe descr…
mart-r 5d24751
CU-869bhm1zy: Separate saving of model card to its own method
mart-r 7e207dd
CU-869bhm1zy: Add tests for required plugins and pipeline descriptions
mart-r aeeb2b3
CU-869bhm1zy: Remove some commented code
mart-r 38f92d3
CU-869bhm1zy: Add provider of each component to pipe description
mart-r b518a36
CU-869bhm1zy: Add a few integration tests for model card / pipe descr…
mart-r c32c679
CU-869bhm1zy: Add another integration tests regarding required plugins
mart-r 4acd473
CU-869bhm1zy: Add plugin author and URL to model packs
mart-r 09272d3
CU-869bhm1zy: Remove random usage of typing based collections for gen…
mart-r 3b1c5e0
CU-869bhm1zy: Update CAT to raise an exception when a model is loaded…
mart-r a5056a0
CU-869bhm1zy: Add a few tests for loading model pack with unavailable…
mart-r 62c0419
CU-869bhm1zy: Improving robustness of entry point metadata by using d…
mart-r 87723c9
CU-869bhm1zy: Add a few simple loader tests
mart-r 1f348ba
CU-869bhm1zy: Make better attempts at providing plugin URL
mart-r 26bd96f
CU-869bhm1zy: Make better attempts at providing plugin auhor details
mart-r 48e22ab
CU-869bhm1zy: Add fallback for checking plugin dependence with improp…
mart-r 846125a
CU-869bhm1zy: Add a simple test for latest changes
mart-r 67b7fce
CU-869bhm1zy: Move getter of component provider to plugin package
mart-r 7d8feed
CU-869bhm1zy: Remove unnecessary argument from method
mart-r d3c3c64
CU-869bhm1zy: Add late registration to of components for plugins upon…
mart-r 5050dec
CU-869bhm1zy: Add missing module
mart-r 5d95537
CU-869bhm1zy: Fix typing issue for 3.11 and 3.12
mart-r a6c3fdd
CU-869bhm1zy: Fix linting issue
mart-r 7ef7e45
CU-869bhm1zy: Fix addon tests
mart-r 9e75390
CU-869bhm1zy: Fix addon tests issue
mart-r d07e38a
CU-869bhm1zy: Hopefully final fix for tests
mart-r 31b3aea
CU-869bhknfm: Fix typo
mart-r be88864
Merge branch 'main' into feat/medcat/CU-869bhm1zy-improve-plugins
mart-r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc - extenal addons would be called
plugins, andaddonswould be internal only, i.e.MetaCAT,RelCAT? but now reading this, does addons still remain internally? for ease, I'm okay with just sticking to one name for all...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to describe the pipeline - core components (ner, linking) and addon components (MetaCAT, RelCAT).
If it's not a core component, it's an addon component. And it gets added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps some clarity:
A component that adds on top of the core components is called an addon. For instance, MetaCAT or RelCAT.
An external source of code that hooks into MedCAT is a plugin. This plugin can provide any component - core or addon. For instance, medcat-gliner is a plugin.