Skip to content

feat: add contains operator into sql criteria converter #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,14 +1,26 @@
import { Criteria } from "../../domain/criteria/Criteria";
import { Filter } from "../../domain/criteria/Filter";
import { Operator } from "../../domain/criteria/FilterOperator";


export class CriteriaToSqlConverter {
private operatorFunctionMap = {
[Operator.EQUAL.valueOf()]: this.toEQUAL,
[Operator.CONTAINS.valueOf()]: this.toCONTAINS,
};

convert(fieldsToSelect: string[], tableName: string, criteria: Criteria): string {
let query = `SELECT ${fieldsToSelect.join(", ")} FROM ${tableName}`;

if (criteria.hasFilters()) {
query = query.concat(" WHERE ");

const whereQuery = criteria.filters.value.map((filter) => {
return `${filter.field.value} ${filter.operator.value} '${filter.value.value}'`;
const operatorFunction = this.operatorFunctionMap[filter.operator.value];
if (!operatorFunction) {
throw new Error(`No function defined for operator ${filter.operator.value}`);
}
return operatorFunction(filter);
});

query = query.concat(whereQuery.join(" AND "));
Expand All @@ -22,4 +34,12 @@ export class CriteriaToSqlConverter {

return `${query};`;
}

toEQUAL(filter: Filter): string {
return `${filter.field.value} = '${filter.value.value}'`;
}

toCONTAINS(filter: Filter): string {
return `${filter.field.value} LIKE '%${filter.value.value}%'`;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,14 @@ describe("CriteriaToSqlConverter should", () => {
"SELECT id, name, email FROM users WHERE name = 'Javier' AND email = '[email protected]' ORDER BY id DESC;",
);
});

it('Generate select with one filter and "CONTAINS" operator', () => {
const actualQuery = converter.convert(
["id", "name"],
"users",
CriteriaMother.withOneFilter("name", "CONTAINS", "tuttodev"),
);

expect(actualQuery).toBe("SELECT id, name FROM users WHERE name LIKE '%tuttodev%';");
});
});