-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rock] Add playwright #1094
[Rock] Add playwright #1094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few notes that you can maybe clear up for me, other than that the code looks good. I can approve it once you answer them.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the latest changes.
🎉 This PR is included in version 3.10.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1091
Summary
Note
All tests are independent. Not need to run them in a successive order
Comparision
Previously, the E2E accumulated 13 minutes (there was a matrix formation with 3 runs: 8 min, 3 min, 2min ). Now, the test runs at 3 minutes (without the need for a matrix). Thus, a reduction of 10 minutes (~79% improvement).
Also, great performance for the tools, working with playwright editor is much better than cypress, way less lag.
Check before Pull Request is ready: