Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use upsell link for feature comparison #4374

Merged
merged 1 commit into from
Feb 3, 2025
Merged

refactor: use upsell link for feature comparison #4374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions inc/customizer/traits/features_upsell.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ trait Features_Upsell {
*/
private function to_json_features() {
return array(
'features_list' => $this->features_list,
'title' => $this->title,
'url_page_section' => $this->url_page_section,
'features_list' => $this->features_list,
'title' => $this->title,
'compare_url' => tsdk_translate_link( tsdk_utmify( 'https://themeisle.com/themes/neve/pricing/#compare', $this->url_page_section ) ),
);
}

Expand Down Expand Up @@ -76,7 +76,7 @@ private function render_features_body() {
<?php echo esc_html( $this->button_text ); ?>
</a>

<a href="<?php echo esc_url_raw( 'https://docs.themeisle.com/article/1176-what-is-the-difference-between-neve-and-neve-pro#' . $this->url_page_section ); ?>" class="button button-link" target="_blank" rel="noopener noreferrer">
<a href="<?php echo esc_url_raw( tsdk_translate_link( tsdk_utmify( 'https://themeisle.com/themes/neve/pricing/#compare', $this->url_page_section ) ) ); ?>" class="button button-link" target="_blank" rel="noopener noreferrer">
<?php echo esc_html__( 'View features comparison', 'neve' ); ?> &rarr;
</a>
</div>
Expand Down Expand Up @@ -114,7 +114,7 @@ private function render_features_body_template() {
</a>
<# } #>

<a href="https://docs.themeisle.com/article/1176-what-is-the-difference-between-neve-and-neve-pro#{{data.url_page_section}}" class="button button-link" target="_blank" rel="noopener noreferrer">
<a href="{{data.compare_url}}" class="button button-link" target="_blank" rel="noopener noreferrer">
<?php echo esc_html__( 'View features comparison', 'neve' ); ?> &rarr;
</a>
</div>
Expand Down
Loading