-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer Improvments #4360
Merged
Merged
Footer Improvments #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soare-Robert-Daniel
added
the
pr-checklist-skip
Allow this Pull Request to skip checklist.
label
Jan 22, 2025
Soare-Robert-Daniel
force-pushed
the
refactor/footer-upsell
branch
6 times, most recently
from
January 27, 2025 14:33
ffcc9db
to
9d41633
Compare
@Soare-Robert-Daniel from what I've tested, it's working well |
Soare-Robert-Daniel
force-pushed
the
refactor/footer-upsell
branch
from
January 28, 2025 08:40
9d41633
to
bdb2252
Compare
pirate-bot
added
the
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
label
Jan 28, 2025
abaicus
approved these changes
Jan 28, 2025
This reverts commit dde936a.
Soare-Robert-Daniel
force-pushed
the
refactor/footer-upsell
branch
from
January 28, 2025 09:55
bdb2252
to
1163a27
Compare
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
pr-checklist-skip
Allow this Pull Request to skip checklist.
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add footer improvements for upsell:
Note
The widget label name was dropped.
Note
The redundant was eliminate to satisfy PHPStan check.
Will affect visual aspect of the product
YES
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/neve-pro-addon/issues/2923