Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Improvments #4360

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Footer Improvments #4360

merged 6 commits into from
Jan 28, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 22, 2025

Summary

Add footer improvements for upsell:

  • Replace the Footer Upsell banner with the new Upsell Section that display the features to unlock.
  • Add upsell for Footer Builder

Note

The widget label name was dropped.

Note

The redundant was eliminate to satisfy PHPStan check.

Will affect visual aspect of the product

YES

Screenshots

Screenshot 2025-01-23 at 10 43 24 Screenshot 2025-01-27 at 16 28 57

Test instructions

  • Check for regressions.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2923

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 22, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 22, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the refactor/footer-upsell branch 6 times, most recently from ffcc9db to 9d41633 Compare January 27, 2025 14:33
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 27, 2025 14:33
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 27, 2025

Plugin build for 1163a27 is ready 🛎️!

@rodica-andronache
Copy link
Contributor

@Soare-Robert-Daniel from what I've tested, it's working well

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 28, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 7b64269 into development Jan 28, 2025
9 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/footer-upsell branch January 28, 2025 09:55
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants