Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary title attributes from brand elements #4352

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

Summary

Remove title attributes with its arrow value since we already have aria-label

Will affect visual aspect of the product

NO

Screenshots

Screenshot 2025-01-09 at 17 06 12

Test instructions

  • Check if the title no longer appears.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2930

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 9, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 9, 2025 15:08
@pirate-bot
Copy link
Collaborator

Plugin build for cc28d0f is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 3207030 into development Jan 22, 2025
19 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/sie-logo-attribute branch January 22, 2025 08:49
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants