Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: onboarding notice #4345

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 17, 2024

Summary

Make the onboarding notice similar to the one in Raft and screenshot on the issue.

Will affect visual aspect of the product

YES

Screenshots

Screenshot 2024-12-17 at 17 19 20 Screenshot 2024-12-17 at 17 19 12 Screenshot 2024-12-17 at 17 19 00 Screenshot 2024-12-17 at 17 18 49

Test instructions

  • Install Neve in a fresh instance
  • Check if the button works
  • Check if the layout is ok

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2909

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 17, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 19, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 19, 2024 09:08
@pirate-bot
Copy link
Collaborator

pirate-bot commented Dec 19, 2024

Plugin build for d73cb1a is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 19, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 5c30549 into development Jan 22, 2025
33 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/onboarding-notice branch January 22, 2025 08:48
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants