Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove survey from dash deps #4221

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 28, 2024

Summary

Remove survey from dashboard script deps.

Will affect visual aspect of the product

NO

Screenshots

2024-03-28_16-30-08.mp4

Test instructions

  • Check the script loading in Neve dashboard like in the video

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2785

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 28, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 28, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 28, 2024
@pirate-bot
Copy link
Collaborator

Plugin build for eea3e0e is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Mar 28, 2024
@preda-bogdan preda-bogdan merged commit 32b7896 into development Mar 29, 2024
38 of 40 checks passed
@preda-bogdan preda-bogdan deleted the fix/survey-deps branch March 29, 2024 11:14
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants