-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with scripts appearing next to single product buttons #2919
Conversation
It looks weird within the gift card page, like here: https://vertis.d.pr/13qPRi https://symbolic-crow.jurassic.ninja/wp-admin/ |
I saw that the issue that @gutoslv mentioned happens when the Sticky add to cart is enabled. It happens both on Gift card page and Product that has WooCommerce Product Add-Ons Ultimate https://vertis.d.pr/f3W7Hw |
Thanks, @gutoslv for letting me know. I made a fix in https://github.com/Codeinwp/neve-pro-addon/pull/1427. When you test this, you should have both PR's. What I ended up doing is to disable the sticky add to cart if the product type is other than This should fix what @irinelenache mentioned too. |
I will close this PR because the solution I provided will produce more issues in the long term. I'll make another PR with a solution that should be more suitable. |
Summary
> *
. If a plugin come and add a script there, the script tag would havedisplay: flex;
NOTE: @preda-bogdan also tried a fix here which was just fixing the issue for noscript and script tags. What I did is to directly target the elements that we have there.
Will affect visual aspect of the product
NO
Screenshots
https://prnt.sc/15otb1h
Test instructions
Closes #2903, Closes #2901, Closes #2915, Closes codeinwp/neve-pro-addon#1414