Skip to content

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Nov 7, 2025

Overview

Wraps focus when tabbing out of InfoTips for both inline + floating variants

@aresnik11 wrote the functional code here, i just DRYed it up and added the tests + sanitized the screenreader text.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1479
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to the InfoTip floating story
  2. See you can tab away + it lands on the InfoTip
  3. Esc still works to close the InfoTip
  4. Go the portal-app PR env + continue there~

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono [Mono PR](https://github.com/codecademy-engineering/mono/pull/11758

@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2025

View your CI Pipeline Execution ↗ for commit 7de0791


☁️ Nx Cloud last updated this comment at 2025-11-07 20:18:28 UTC

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

@dreamwasp dreamwasp marked this pull request as ready for review November 7, 2025 21:00
@dreamwasp dreamwasp requested a review from a team as a code owner November 7, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants