-
-
Notifications
You must be signed in to change notification settings - Fork 369
London | 26-ITP-January | Eugenie Ahangama | Sprint 1 | Wireframe to Web Code #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
codeschris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes follow set guidelines! Good work!
|
Hi @codeschris, thanks for the review. I noticed the PR is still marked as 'needs review'. When you get a moment, could you please update it to 'reviewed'? Only volunteers can change the label. Thank you! |
Hey @Eugenie-A. I have updated it to 'reviewed'. |

Learners, PR Template
Self checklist
Changelist
The purpose of this PR is to implement the webpage structure and layout from the provided wireframe, ensuring semantic HTML, accessible styling and a complete functional design.
I added semantic HTML structure, including a header with a title and description, three unique articles, and a footer. I then applied CSS to recreate the wireframe layout, using a grid for the articles, styling the header and footer, and ensuring the footer stays fixed at the bottom of the page.
I also added accessible link and card styling, and ensured the page scored 100 in the Lighthouse Accessibility audit. All changes were committed in small, meaningful commits and pushed to the feature/wireframe branch.
Questions
I have no questions at the moment.