Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 143 --refactor upload to ckan, check for package existence before… #144

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

thepsalmist
Copy link
Contributor

@thepsalmist thepsalmist commented Feb 14, 2025

Description

This PR refactors the command to upload_to_ckan, introduces checking for package existence before creating a new ons

Fixes #143

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot 2025-02-14 at 15 24 34

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@thepsalmist thepsalmist self-assigned this Feb 14, 2025
@thepsalmist thepsalmist added bug Something isn't working chore labels Feb 14, 2025
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link

@VinneyJ VinneyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However the handle() function is super long maybe we might consider breaking it down abit.

@thepsalmist thepsalmist merged commit f52c30d into master Feb 17, 2025
2 checks passed
@thepsalmist thepsalmist deleted the fix/openafrica-datasets-upload branch February 17, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Datasets Upload to OpenAfrica
3 participants