Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Define comment strings for each language #65

Merged
merged 7 commits into from
Apr 11, 2024
Merged

feat: Define comment strings for each language #65

merged 7 commits into from
Apr 11, 2024

Conversation

Cubik65536
Copy link
Contributor

@Cubik65536 Cubik65536 commented Feb 9, 2024 •
edited
Loading

Signed-off-by: Qian Qian "Cubik"‎ [email protected]

Description

Add comment string definitions for each language so the feature to press ⌘ + / to comment a line or a block of codes can be provided.

Related Issues

  • n/a

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

n/a

@Cubik65536
Copy link
Contributor Author 

CodeLanguage+Definitions.swift:463:1: error: File Length Violation: File should contain 400 lines or less: currently contains 463 (file_length)

That's even with some definitions missing...

Any ideas what we can do with this? /cc @thecoolwinter

@Cubik65536
style: Fix some SwiftLint issue
e9d0459 
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536
feat: Add Java documentation string
04d4f62 
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536 Cubik65536 marked this pull request as ready for review March 15, 2024 23:58
@Cubik65536 Cubik65536 changed the title [WIP] feat: Define comment strings for each language feat: Define comment strings for each language Mar 16, 2024
@austincondiff austincondiff mentioned this pull request Mar 24, 2024
Open
austincondiff
austincondiff approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the effort here!

@FastestMolasses FastestMolasses merged commit 534853a into CodeEditApp:main Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FastestMolasses FastestMolasses FastestMolasses approved these changes

@matthijseikelenboom matthijseikelenboom matthijseikelenboom approved these changes

@austincondiff austincondiff austincondiff approved these changes

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cubik65536 @austincondiff @matthijseikelenboom @FastestMolasses @nervenes