Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Task Dropdown Crash #1956

Merged
merged 13 commits into from
Jan 8, 2025
Merged

Fix Task Dropdown Crash #1956

merged 13 commits into from
Jan 8, 2025

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Fixes a crash when opening the task dropdown menu.
  • Improves accessibility in the activity viewer, dropdowns, and workspace settings window.
  • Adds UI tests for the dropdown menu and the entire task creation workflow.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

One of the new UI Tests

task.tests.mov

@thecoolwinter thecoolwinter added bug Something isn't working tests labels Jan 8, 2025
@thecoolwinter thecoolwinter mentioned this pull request Jan 8, 2025
Merged
6 tasks
@thecoolwinter thecoolwinter merged commit 580b249 into CodeEditApp:main Jan 8, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/task-dropdown-crash branch January 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FastestMolasses FastestMolasses FastestMolasses approved these changes

@0xWDG 0xWDG 0xWDG approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecoolwinter @0xWDG @FastestMolasses