Fix Getting Stuck in Sub-View within Settings #1942
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side the nested accounts page - Sidebar toggle is completely removed on versions above macOS 14+ - Known Issue: Sidebar toggling is not reliably hidden on versions macOS 13 and below due to the introduction of a NavigationStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an initial attempt at resolving the below issue. There are a few things of note here before this can be merged. The first is that the introduction of a NavigationStack within individual tab views inadvertently causes the sidebar toggle to remain visible on versions of macOS 13 and below. I have addressed this issue in macOS 14+ by using the new toolbar remove API. The other thing is that I have only fixed this in one area thus far, inside account settings. I did not make a universal solution yet as I wanted to get feedback as to how we would handle this. Ideally, we would have an automatic way to handle subviews.
Related Issues
Checklist
Screenshots
Screen.Recording.2024-12-03.at.1.18.32.PM.mov