Source Control Settings #1926
Open
Source Control Settings #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we disable file events on the .git folder. Enabling git settings by default.
…n Settings by clearing the current branch stored in the source control manager.
…isabled automatic fetching is disabled.
…e the users global git config instead of CodeEdit settings. Introduced Limiter.debounce and Limiter.throttle.
…abled, if disabled no merge commits are displayed.
austincondiff
requested review from
0xWDG,
bombardier200,
FastestMolasses,
EstebanBorai,
thecoolwinter,
Wouter01 and
tom-ludwig
FastestMolasses
requested changes
Nov 2, 2024
CodeEdit/Features/Settings/Pages/SourceControlSettings/SourceControlGitView.swift
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SourceControlSettings/SourceControlGitView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SourceControlSettings/SourceControlGitView.swift
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SourceControlSettings/SourceControlGeneralView.swift
Outdated
Show resolved
Hide resolved
…h excluded files list and ignored files list to use new shared glob list view.
tom-ludwig
requested changes
Nov 7, 2024
CodeEdit/Features/Settings/Pages/SourceControlSettings/Models/IgnorePatternModel.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SourceControlSettings/Models/SourceControlSettings.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SourceControlSettings/SourceControlGeneralView.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/SourceControlSettings/SourceControlGitView.swift
Outdated
Show resolved
Hide resolved
…mentation and TODO.
…e in the users .gitignore_global file. Users can now reorder ignored files. Buttons were added in settings to open .gitconfig and .gitignore_global in an editor.
FastestMolasses
requested changes
Dec 4, 2024
| ignoreGlobPatterns.append(GlobPattern(value: "")) | ||
| } | ||
|
|
||
| func removePatterns(_ selection: Set<UUID>? = nil) { |
There was a problem hiding this comment.
Because we are using a set here, we can take advantage of its constant look up times:
if let selection, !selection.isEmpty {
let patternsToRemove = Set(selection.compactMap { getPattern(for: $0) })
ignoreGlobPatterns.subtract(patternsToRemove)
}
self.selection.removeAll()
| @@ -130,6 +133,15 @@ struct WorkspaceView: View { | |||
| : themeModel.selectedLightTheme | |||
| } | |||
| } | |||
| .onChange(of: sourceControlIsEnabled) { newValue in | |||
| if !newValue { | |||
There was a problem hiding this comment.
Im still confused by this, can someone take a look at this too? The branches seem to be inverted. When source control gets enabled, we will set the branch to nil. When it gets disabled, we refresh the current branch.
| FileManager.default.createFile(atPath: fileURL.path, contents: nil) | ||
| } | ||
|
|
||
| NSDocumentController.shared.openDocument( |
There was a problem hiding this comment.
Will this need an await like in line 224 in the openGitIgnoreFile function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our source control settings currently do not work. This PR enables many of these settings. Some of these settings use the users git config so we are introducing functionality to get and set based on config keys. As the user types, we want to debounce the set function, so we are also introducing
Limiterwhich hasdebounceandthrottlemethods.Related Issues
Checklist
Screenshots
Screen.Recording.2024-10-28.at.10.30.31.PM.mov
Screen.Recording.2024-10-28.at.10.50.04.PM.mov
Screen.Recording.2024-10-28.at.10.58.13.PM.mov