Remove files related to plugin extension system #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter01 <[email protected]>
Wouter01
requested review from
lukepistrol,
matthijseikelenboom,
0xWDG,
austincondiff,
KaiTheRedNinja and
thecoolwinter
0xWDG
previously approved these changes
Mar 23, 2023
Signed-off-by: Wouter01 <[email protected]>
matthijseikelenboom
approved these changes
Mar 23, 2023
0xWDG
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are still lots of files (and some dependencies) present related to an extension system based on plugins. CodeEdit won't support extensions which work with plugins due to some security risks. Instead, CodeEdit will use Apple's ExtensionKit and later on a JS API which will work similar to ExtensionKit (with XPC). Therefore, these files are not needed and can be removed.
This PR also temprarily removed the dependency on CodeEditKit. This will be added again later on when the package will be actively used.
Related Issues
Checklist