Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 12 #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DerTechie
Copy link

Issue:

What I did

  • Updated composer requirements for Laravel 12 packages

How to test

  • run composer install
  • run vendor/bin/phpstan
  • run vendor/bin/phpunit

Also tested Soap requests on a local project of mine. Seems to work.

Does this need an update to the documentation?

I don't think so

@DerTechie
Copy link
Author

Not sure about the composer.lock. It has been removed automatically due to the presence of it within the .gitignore file.

@func0der
Copy link

func0der commented Apr 2, 2025

Not sure about the composer.lock. It has been removed automatically due to the presence of it within the .gitignore file.

Theoretically a library does not need one, since its dependencies are mostly in a range of allowed values. You always have min and max versions that need to be tested. Composer.lock would potentially hinder those changes.

So I guess it should be fine.
LEt's see what the maintainer has to say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants