-
Notifications
You must be signed in to change notification settings - Fork 0
SANC-60-vehicle-logs-create-api-endpoints-and-connect-to-frontend #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
promatty
merged 11 commits into
main
from
SANC-60-vehicle-logs-create-api-endpoints-and-connect-to-frontend
Apr 14, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d5f44e5
SANC60: add log.id to form initial values
wesleylui 51e0e99
SANC60: create api endpoints and connect to vehicle logs frontend
wesleylui 160833e
Merge branch 'main' of https://github.com/Code-the-Change-YYC/salvati…
wesleylui 7fa9eec
SANC60: add vehicle to survey and post-trip-schema
wesleylui 8125a00
SANC60: fix admin navbar vehicle log button routing
wesleylui c87f2a8
SANC60: add vehicle field to survey frontend
wesleylui bbf9a96
SANC60: driver log auto created when driver completes survey
wesleylui fb2b073
SANC60 change vehicle field to dropdown of salvation army cars
wesleylui 7726848
SANC60: vehicle in db stuff--check PR comment
wesleylui 5f4adee
SANC60: fix odometer validations
wesleylui 5ce6ed3
SANC60: update odometer validation messages
wesleylui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent disabled state for Vehicle field when trip is cancelled.
In
TripSurveyModal.tsx(line 111), the Vehicle<Select>is disabled whentripCompletionStatus === BookingStatus.CANCELLED, but this implementation lacks that behavior. The validation insurveyNotification.tsxskips vehicle validation for cancelled trips, so the UI should match by disabling the field.Proposed fix
<Select withAsterisk label="Vehicle" placeholder="Select a vehicle" data={AVAILABLE_VEHICLES} searchable key={form.key("vehicle")} {...form.getInputProps("vehicle")} error={form.errors.vehicle} + disabled={form.values.tripCompletionStatus === BookingStatus.CANCELLED} />🤖 Prompt for AI Agents