Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the 'go to top' button to a circular button with an arrow on it #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

attreyee-muk
Copy link

Related Issuse or bug

  • Info about Issue or bug

Fixes: #[issue number that will be closed through this PR]

Proposed Changes

  • Info about changes Goes here

Additional Info

  • Anything related Issues

Screenshots

Original Updated
original screenshot **updated screenshot **

@attreyee-muk
Copy link
Author

Made the required changes. Please accept it.

@kashish-d
Copy link
Contributor

Hey @A-Muk
This is what i see
image

-First make your remote repo fully updated with the current master branch.
-You have to make changes to the grammar and fix the alignment of the about section as well

  • Unfortunately this arrow is not aligned properly as mentioned in the screenshot. Go with the previous button that is currently on the home page. In the about us page only, make it the same arrow button
    image

@attreyee-muk
Copy link
Author

Sorry I forgot to add the screenshots, but when I had executed the program, the alignment of the arrow was totally fine. No problem, I will try and work on this issue and as well as on the grammar and the alignment of the about section as you told.

@attreyee-muk
Copy link
Author

Sir, I have shared the screenshots of the website. I also corrected some grammatical errors. Please see and do let me know if I should do more changes to it.
Screenshot 2021-10-15 at 12 49 06 PM
Screenshot 2021-10-15 at 12 57 41 PM

Copy link
Member

@unnati914 unnati914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! @A-Muk, your branch is having some issues, please fix them.

@attreyee-muk
Copy link
Author

Okay @unnati914 ! Please see if the changes I made is correct through the ss. If it is, then I will make another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants