[CHORE] Improved naming of things.

CoSchedule · Nov 15, 2018 · 06e4528 · 06e4528
1 parent 317492c
commit 06e4528
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/auth.js b/auth.js
@@ -1,6 +1,6 @@
 const { requestWithRetries, isRequestError, isStatusCodeError } = require('./requestPromiseUtils');
 
-const retryHandler = (err, nextTryCount) => {
+const shouldRetry = (err, nextTryCount) => {
   if (nextTryCount > 5) {
     return false;
   }
@@ -32,7 +32,7 @@ module.exports = (zuoraClient) => {
       json: true,
     };
 
-    const response = await requestWithRetries(options, retryHandler, computeRetryDelay);
+    const response = await requestWithRetries(options, shouldRetry, computeRetryDelay);
     if (!response) {
       throw new Error('ZuoraJS: Auth: Empty Response');
     }

diff --git a/requestPromiseUtils.js b/requestPromiseUtils.js
@@ -1,13 +1,13 @@
 const requestPromise = require('request-promise');
 const requestPromiseErrors = require('request-promise/errors');
 
-const requestWithRetries = async (requestOptions, retryHandler, computeRetryDelay) => {
+const requestWithRetries = async (requestOptions, shouldRetry, computeRetryDelay) => {
   const makeRequest = async (tryCount) => {
     let response;
     try {
       response = await requestPromise(requestOptions);
     } catch (err) {
-      if (!retryHandler || !retryHandler(err, tryCount)) {
+      if (!shouldRetry || !shouldRetry(err, tryCount)) {
         throw err;
       }