Changed GetRawResponseContent to return content if there is some rega… #61
Conversation
…rdless of HttpStatusCode
…tionException. If it was a 404 you would not know otherwise.
|
Return more information to the developer when there's a JsonSerializationException. If it was a 404 you would not know otherwise. |
|
I have faced same issue but returning null should not be needed? (I know the tests are expecting null, but this can be changed to asserting string.IsNullOrEmpty() - this could however be a problem with compatibility) |
|
I suppose returning null will maintain compatibility and, if there is no content, it will behave as it did before. Are there any alternatives that would not break compatibility? |
|
You are breaking compatibility under all circumstances by returning data where it before returned null. The pull request are also breaking compatibility for success status codes since now the libary returns null where it before returned a empty string. I really don't think that the users of this libary is checking for null to determine if a request has failed before checking the statuscode. So I really think you should be consistent and just returing the response and change the tests. |
2 participants
…rdless of HttpStatusCode