Freature/product options zigzag #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upswp
approved these changes
Jul 20, 2024
upswp
left a comment
upswp
left a comment
There was a problem hiding this comment.
이 설계에 대한 테스트 코드 및 API를 통해서 원하는 값들이 잘 나오는지 분석해보시면 좋겠어요!
1. 필요 없는 Mybatis 레거시를 정리했습니다. 2. 기존 Mybatis 레거시로 인해 `~JPARepository`, `~Entity` 네이밍의 클래스를 `~Repository`, pure한 엔티티 이름으로 변경했습니다. 3. ProductLine의 모든 상품 Paging도 Category별 조회와 마찬가지로 batch_fetch를 적용해 성능을 개선했습니다. 4. 연관성이 있는 로직들의 네이밍을 전부 수정했습니다.
- `@Embadabble` 로 임베디드 타입 으로 정의 - `@ElementCollection`, `@CollectionTable` 로 임베디드타입 컬렉션으로 관리하도록 구현
…roductImage DTO 생성
Ogu1208
force-pushed
the
freature/product-Options-ZIGZAG
branch
from
43ed5b3 to
0e3366f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.