Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update MSI table #1459

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix: update MSI table #1459

merged 2 commits into from
Jun 28, 2024

Conversation

khurrammaqbool
Copy link
Collaborator

@khurrammaqbool khurrammaqbool commented Jun 28, 2024

Description

Update MSI final table.

Added

  • [Description]

Changed

  • MSI final table

Fixed

  • [Description]

Removed

  • [Description]

Documentation

  • N/A
  • Updated Balsamic documentation to reflect the changes as needed for this PR.
    • [Document Name]

Tests

Feature Tests

  • N/A
  • Test [Description]
    • [Screenshot]

Pipeline Integrity Tests

  • Report deliver (generation of the .hk file)
    • N/A
    • Verified
  • TGA T/O Workflow
    • N/A
    • Verified
  • TGA T/N Workflow
    • N/A
    • Verified
  • UMI T/O Workflow
    • N/A
    • Verified
  • UMI T/N Workflow
    • N/A
    • Verified
  • WGS T/O Workflow
    • N/A
    • Verified
  • WGS T/N Workflow
    • N/A
    • Verified
  • QC Workflow
    • N/A
    • Verified
  • PON Workflow
    • N/A
    • Verified

Clinical Genomics Stockholm

Documentation

  • Atlas documentation
    • N/A
    • Updated: [Link]
  • Web portal for Clinical Genomics
    • N/A
    • Updated: [Link]

Panel of Normal specific criteria

User Changes

  • N/A
  • This PR affects the output files or results.
    • User feedback is considered unnecessary because [Justification].
    • Affected users have been included in the development process and given a chance to provide feedback.

Infrastructure Changes

  • Stored files in Housekeeper
    • N/A
    • Updated: [Link]
  • CG (CLI and delivered/uploaded files)
    • N/A
    • Updated: [Link]
  • Servers (configuration files on Hasta)
    • N/A
    • Updated: [Link]
  • Scout interface
    • N/A
    • Updated: [Link]

Checklist

Important

Ensure that all checkboxes below are ticked before merging.

For Developers

  • PR Description
    • Provided a comprehensive description of the PR.
    • Linked relevant user stories or issues to the PR.
  • Documentation
    • Verified and updated documentation if necessary.
  • Tests
    • Described and tested the functionality addressed in the PR.
    • Ensured integration of the new code with existing workflows.
    • Confirmed that meaningful unit tests were added for the changes introduced.
    • Checked that the PR has successfully passed all relevant code smells and coverage checks.
  • Review
    • Addressed and resolved all the feedback provided during the code review process.
    • Obtained final approval from designated reviewers.

For Reviewers

  • Code
    • Code implements the intended features or fixes the reported issue.
    • Code follows the project's coding standards and style guide.
  • Documentation
    • Pipeline changes are well-documented in the CHANGELOG and relevant documentation.
  • Tests
    • The author provided a description of their manual testing, including consideration of edge cases and boundary
      conditions where applicable, with satisfactory results.
  • Review
    • Confirmed that the developer has addressed all the comments during the code review.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@khurrammaqbool khurrammaqbool self-assigned this Jun 28, 2024
@khurrammaqbool khurrammaqbool requested a review from a team as a code owner June 28, 2024 07:36
@khurrammaqbool khurrammaqbool linked an issue Jun 28, 2024 that may be closed by this pull request
3 tasks
@khurrammaqbool khurrammaqbool added this to the Release 16 milestone Jun 28, 2024
@khurrammaqbool
Copy link
Collaborator Author

image

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (7d529e6) to head (3cec71e).
Report is 10 commits behind head on develop.

Current head 3cec71e differs from pull request most recent head 19bfe34

Please upload reports for the commit 19bfe34 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1459   +/-   ##
========================================
  Coverage    99.48%   99.48%           
========================================
  Files           40       40           
  Lines         1932     1944   +12     
========================================
+ Hits          1922     1934   +12     
  Misses          10       10           
Flag Coverage Δ
unittests 99.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathiasbio
Copy link
Collaborator

Nice! Do you think we need to high some explanation for what the scores mean, or is it up to the clinicians to understand how to use the score?

@khurrammaqbool
Copy link
Collaborator Author

khurrammaqbool commented Jun 28, 2024

Nice! Do you think we need to high some explanation for what the scores mean, or is it up to the clinicians to understand how to use the score?

The references from the article would be nice to know more about what the score mean. Perhaps, these two review articles may be a good starting point: https://doi.org/10.3389/fonc.2018.00621 and https://doi.org/10.1093/gbe/evq023.
This request to add MSI came from the customer so I am sure they know what the score mean.

@mathiasbio
Copy link
Collaborator

Alright! 👍

Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🌟

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please use the template Test section in your next PRs with a description of what has been tested, instead of posting the results in separate messages. Thanks!

Copy link

@khurrammaqbool khurrammaqbool merged commit 8ab0e4d into develop Jun 28, 2024
6 checks passed
@khurrammaqbool khurrammaqbool deleted the fix/msi_table branch June 28, 2024 08:28
@mathiasbio mathiasbio mentioned this pull request Oct 17, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

[User Story] Add MSI analysis
3 participants