Documentation of the symbolic outputs functionalities

[jodemaey]

No description provided.

[jodemaey]

Hi @ushham ,

I checked the Fortran tabulation issue and it looks fine.

On the other hand, setting continuation_variables=None is currently similar to continuation_variables=[] and returns tendencies where all the substitutions have been done. So there is a problem there.

I think that after this is solved we can merge.

Cheers,

Jonathan

[ushham]

I have fixed the above issue that you raised. It was occurring because there was a mix of using parameter objets and a dict storing the symbols. The use of the dict was a hangover from earlier versions of this and should have been removed once you implemented the new parameter class.

[jodemaey]

Regarding this comment, actually when I generate fully symbolic tendencies, there is no trace of pi, neither in Python nor in Fortran. I think Sympy already replaces it in the inner products, so I think we can drop pi from these dicts.

[ushham]

I wonder if the outputs of the inner products still include pi, I don't think I would have included this for no reason, but its clearly not needed so can be removed

[jodemaey]

If think it depends on the way you ask Sympy to output them, but clearly here the pi's are already converted to numerics.

[ushham]

Regarding this comment, actually when I generate fully symbolic tendencies, there is no trace of pi, neither in Python nor in Fortran. I think Sympy already replaces it in the inner products, so I think we can drop pi from these dicts.

I also note that I was subbing conjugations which are not needed. I can remove these

[jodemaey]

When you increase resolution, at some point conjugations appear.

[jodemaey]

Good, in the end, the user can still substitute expressions if he wants anyway.
I think we are good to merge. @ushham , can you formally make the review and accept the PR, then I can merge.

[ushham]

Yes exactly, it is still flexible for subs from the user. Ok all looks good to me :)

[jodemaey]

Ok this is merged. I will proceed to merge to master and then release. Good job !