Skip to content

Conversation

@jodemaey
Copy link
Member

No description provided.

@jodemaey
Copy link
Member Author

Hi @ushham ,

I have created this PR because we need to move on with the symbolic outputs.
There is a merge conflict, but it is not a big deal (it is in a docstring).

How I see this evolves is that we still clean some stuffs (mainly notebooks and tests), then we merge this PR.
Then we start a new branch to document the new functionalities in the doc.

See you soon to discuss this.

J.

@jodemaey
Copy link
Member Author

jodemaey commented Mar 11, 2025

Hi @ushham ,

So I have deleted the old notebooks and created 2 new ones in the notebooks/symbolic_outputs folder.
Please check them. Also I resolved the merge conflict.

A problem remains with the tests. They are not passing and I think I know why, and we should discuss that asap. Then I think you should review one last time and we can merge.

J.

@jodemaey jodemaey requested a review from ushham March 12, 2025 10:13
Copy link
Collaborator

@ushham ushham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the version number in the toml file?

@jodemaey
Copy link
Member Author

Not yet. This is not the final PR before the release.

Copy link
Collaborator

@ushham ushham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, this looks good to me

@jodemaey jodemaey merged commit 72564aa into develop Mar 12, 2025
11 checks passed
@jodemaey jodemaey deleted the feature/symbolic_outputs branch March 28, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants