switch os truststore libraries #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches OS trust-store handling from
pip-system-certs
totruststore
and inject at startup.This is happening because
pip-system-certs
pulls inpip
transitively. Some hardened Docker image scanners fail any image that containspip
because CVE-2018-20225 gets flagged even though it’s considered intended behavior. See issue #70.We only used
pip-system-certs
to auto-enable system CA bundles; we don’t needpip
for that.This is achieved by:
pip-system-certs
from dependencies and addingtruststore>=0.10
.mcp_clickhouse/__init__.py
, call:This keeps behavior the same as before, using OS trust store by default and silently falls back if injection isn’t possible. As a result, runtime images no longer include
pip
, reducing scanner friction and addressing #70’s concern.Closes #70