[libc++] Drop routing to nonexistent locale shims.#89
Open
jmcarp wants to merge 1 commit intoClickHouse:ClickHouse/release-22.xfrom
Open
[libc++] Drop routing to nonexistent locale shims.#89jmcarp wants to merge 1 commit intoClickHouse:ClickHouse/release-22.xfrom
jmcarp wants to merge 1 commit intoClickHouse:ClickHouse/release-22.xfrom
Conversation
LLVM previously included shims for strtoll_l and strtoull_l for distributions that don't expose those functions. However, with the upgrade to 22.x, LLVM learned to parse integers itself, without relying on those functions, and dropped the shim. Routing to __locale_dir/locale_base_api/musl.h now fails, since the shim was removed on upgrade. This patch drops the now-unnecessary routing to a file that doesn't exist. Note that we don't need to backport this change to upstream LLVM, since the shim and routing to it are already removed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM previously included shims for strtoll_l and strtoull_l for distributions that don't expose those functions. However, with the upgrade to 22.x, LLVM learned to parse integers itself, without relying on those functions, and dropped the shim. Routing to __locale_dir/locale_base_api/musl.h now fails, since the shim was removed on upgrade.
This patch drops the now-unnecessary routing to a file that doesn't exist. Note that we don't need to backport this change to upstream LLVM, since the shim and routing to it are already removed there.
cc @alexey-milovidov