[JDBC-V2] Fix some metadata resultsets return inconsistent data on getObject()
#2540
+1,566
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set for database metadata
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
mzitnik
approved these changes
Aug 19, 2025
|
mzitnik
reviewed
Aug 20, 2025
|
|
||
| private boolean closed; | ||
|
|
||
| private Map<String, Integer> columnMap; |
There was a problem hiding this comment.
Can we use ImmutableMap, or at least let's init with column count since we have this information
|
Since there was a change in metadata retrieval, let's verify that we did not break metabase, tableau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseMetadatahas two methodsgetColumnsandgetTypeInfowhich return aResultSet. This result sets should contain ClickHouse data type name to an integer constant. Previously data was calculated on server but SQL became too hard to maintain. ThenMetadataResultSetImplwas added to fix the issue to let override some columns. However it is not a good solution because need to do many compensation logic.This PR implements a new approach:
DATA_TYPEDATA_TYPEcolumn values while loadingIt solves another problem - query for a DB metadata is done using internal statement that is never closed. Returned result set also may stay unclosed what will leak connections. Detached result set has not statement and let free resources one result set is returned.
Closes #2396
Checklist
Delete items not relevant to your PR: