Add JSON support #450
Draft
Add JSON support #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
commented
Nov 19, 2025
|
|
||
| GenericColumnTestCase<ColumnString, &makeColumn<ColumnString>, std::string, &MakeStrings>, | ||
| GenericColumnTestCase<ColumnFixedString, &makeColumn<ColumnFixedString, 12>, std::string, &MakeFixedStrings<12>>, | ||
| GenericColumnTestCase<ColumnJSON, &makeColumn<ColumnJSON>, std::string, &MakeJSONStrings>, |
Contributor
Author
There was a problem hiding this comment.
This is the only test that fails. It crashes with this error:
libc++abi: terminating due to uncaught exception of type std::__1::system_error: closed: Operation now in progress
I presume it's because it fails to turn the protocol JSON format into a string.
Implemented the same as String, which seems to work fine except for round-tripping. I assume it's not actually a string in the protocol so it will need a different format. But hopefully the rest of the infrastructure for it is helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the same as String, which seems to work fine except for round-tripping. I assume it's not actually a string in the protocol so it will need a different format. But hopefully the rest of the infrastructure for it is helpful.
Not a blocker for my project; JSON works fine for now with the HTTP interface.