Conversation
Member
Author
Member
|
Related/Duplicate to #4593 But happy to close that and keep working here! |
Member
Author
|
oh no, we can use that. Do you want to copy over any tests before i close and delete the branch? |
Member
|
Happy either way! Close one of the two PRs; I have no problem which one! |
Member
Author
|
the other one is more complete so i moved the tests over there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may not work. Noticed by @SimonDanisch
I also changed the HydrostaticFreeSurfaceModel test to light up more code paths.