Skip to content

fix: julia 1.11 list comprehension bug + use Makie #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

haakon-e
Copy link
Member

@haakon-e haakon-e commented Jun 23, 2025

Purpose

fixes #600

also took the liberty to change the file from Plots to Makie :)

To-do

Content


  • I have read and checked the items on the review checklist.

@haakon-e
Copy link
Member Author

haakon-e commented Jun 23, 2025

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (53e3d43) to head (38aeed5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files          47       47           
  Lines        1752     1752           
=======================================
  Hits         1625     1625           
  Misses        127      127           
Components Coverage Δ
src 94.08% <ø> (ø)
ext 69.79% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sajjadazimi sajjadazimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@haakon-e haakon-e force-pushed the he/fix-julia-1-11-list branch 3 times, most recently from 68d1af3 to 9c48497 Compare June 25, 2025 00:50
@haakon-e haakon-e force-pushed the he/fix-julia-1-11-list branch from 9c48497 to 38aeed5 Compare June 25, 2025 17:06
@haakon-e haakon-e enabled auto-merge June 25, 2025 17:06
@haakon-e haakon-e merged commit 3c9f956 into main Jun 25, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault in docs/src/plots/Microphysics1M_plots.jl
2 participants