Merged
Conversation
issue: #91
- 업비트 호가 정책에 따른 단가 적용 issue : #91
- fixed-rate : 5초마다 주문 실행 - order-level : 한번 실행 시 숫자 갯수만큼 실행 및 오더북에 해당하는 주문 - corn : 단가 수집 기간, 주문 가격 단위 설정 issue : #93
…tybot # Conflicts: # src/main/java/com/cleanengine/coin/realitybot/service/OrderGenerateService.java
- 매일 자정으로 재수정
- 초기 선형 보간 및 refactor
- 코인원 추가 issue: #39
…nto feat/realitybot
caniro
previously approved these changes
Jun 5, 2025
Contributor
caniro
left a comment
caniro
left a comment
There was a problem hiding this comment.
테스트랑 리팩토링 많이 하셨네요.. 고생하셨습니다!
src/main/java/com/cleanengine/coin/realitybot/api/BithumbAPIClient.java
Outdated
Show resolved
Hide resolved
Contributor
Author
There was a problem hiding this comment.
넵 시세를 이탈 시켰을 때 어떻게 작동하는 지 보는 테스트 용도가 맞습니다.
Contributor
There was a problem hiding this comment.
개인적으로 프로덕션 코드랑 테스트 코드는 분리되는 게 나을 것 같은 느낌이 드네요
caniro
reviewed
Jun 5, 2025
src/main/java/com/cleanengine/coin/realitybot/api/UnitPriceRefresher.java
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업내용
🐞 이슈사항