Pull Request for Space Travelers' Hub App #44
Conversation
…figuration for react-redux, github-workflows and the commands to install react-redux, redux-logger and react-router-dom
…as downloaded from the link that appear on the requirements
…issions.js and Myprofile.js files
…es rocketsSlice.js and rocketsActions.js and the folder missions with the files missionsSlice.js and missionsActions.js
… React and creating new tag elements inside app function adding the nav with a list and inside it the Navlinks to rockest, missions and my-profile with their routes
…-setup Feature/config and basic setup
…components Feature/setup nav links components
Feature/header setup
…reStore and the store with the reducer for rockets
…dy added by default, change the activeClassname by activeclassName and add the importation of store from redux/store
…itial state, the synchronous actions that will update that state, and the reducer that will update the state based on those actions
…). These actions will be responsible for making the API call and dispatching synchronous actions to update the state with the data received from the API.
…nterface. Use the useSelector hook to get the data from the state stored in Redux and the useDispatch hook to dispatch the actions defined
…fetchRocketsdata function
Feature/fetch data rockets
…lasses to make the styles
Feature/joining action
…issions Display joined missions
Feature/testing rockets
Testing missions
Relocate the link to the project deployment.
Details/update readme
ClaudiaRojasSoto
added
documentation
There was a problem hiding this comment.
Hello @ClaudiaRojasSoto && @CesarHerr 👋 ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights 🍾
- Descriptive pull request message ✍️
- Professional README 📜
- Well-written commit messages ✍️
- All requirements met and site is working as expected ⚙️
Optional suggestions 💭
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏 💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Lucas-Masaba in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <header className="header"> | ||
| <div> | ||
| <img src={planet} alt="logo" /> | ||
| <h1>Space Traveler's Hub</h1> | ||
| </div> | ||
| <nav> | ||
| <ul> | ||
| <li className="nav-item"> | ||
| <NavLink activeclassname="active" to="/"> | ||
| Rockets | ||
| </NavLink> | ||
| </li> | ||
| <li className="nav-item"> | ||
| <NavLink activeclassname="active" to="/missions"> | ||
| Missions | ||
| </NavLink> | ||
| </li> | ||
| <li className="nav-item"> | ||
| <NavLink activeclassname="active" to="/my-profile"> | ||
| My Profile | ||
| </NavLink> | ||
| </li> | ||
| </ul> | ||
| </nav> |
There was a problem hiding this comment.
[OPTIONAL]
- It would look much cleaner if this navbar was in a file in the component folder and imported here.
There was a problem hiding this comment.
@Lucas-Masaba You are right! this is a great idea, thank you very much for your review 😄
| [SpaceTravelers.webm](https://github.com/ClaudiaRojasSoto/Space_Travelers/assets/111262493/c6a3917d-a45b-4818-9d94-191a8192c06c) | ||
| ## 🚀 Live Demo <a name="live-demo"></a> | ||
|
|
||
| > You can see the live demo of this project: [click here](https://space-travelers-z8vp.onrender.com) |
There was a problem hiding this comment.
Awesome that you deployed your project 🏄
Description
This Pull Request introduces the work done in the
developbranch to themasterbranch of our Space Travelers' Hub app. The application meets all project requirements. It operates as a web platform that provides commercial and scientific space travel services. Users can book rockets and join selected space missions.Main Changes
Fulfilled Requirements
We look forward to your feedback and/or approval to proceed with the merge.
Thank you for your time and consideration.
Best regards,
@CesarHerr
@ClaudiaRojasSoto