Skip to content

Fix dispatch roster visibility follow-ups - #430

Open
Clarion1631 wants to merge 1 commit into
mainfrom
geordi/t_d31f4b92
Open

Fix dispatch roster visibility follow-ups#430
Clarion1631 wants to merge 1 commit into
mainfrom
geordi/t_d31f4b92

Conversation

@Clarion1631

Copy link
Copy Markdown
Owner

What changed

  • Keeps a new drag visible while its persisted roster membership hydrates, while FINANCE stays excluded.
  • Restores the dispatch-role regression set and pins missing membership fields as fail-closed.
  • Applies the per-person dispatch switch to manager support, fixes the eight-column Team empty state, and uses selected-day dispatch copy.

Verification

  • PASS: 28 targeted dispatch tests
  • PASS: npm run typecheck
  • PASS: scoped ESLint (22 pre-existing warnings, 0 errors)
  • PARTIAL: production build compiles and typechecks, then cannot collect page data in this clean worktree because NEXTAUTH_SECRET is intentionally absent.

REVIEW: VERDICT: UNREVIEWED (codex: failed: TIMEOUT after 300s; claude: ran: no VERDICT line)
Verdict artifact: C:\Users\jat00\AppData\Local\Temp\gtr-review-t_d31f4b92-verdict.md

After merge: opt in Richard and CJ in Team, then verify the Dispatch roster.

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
probuild Ready Ready Preview Aug 29, 2026 11:04pm

Request Review

@github-actions

Copy link
Copy Markdown
  1. ScheduleBoard.tsx:588 changes missing membership to fail-open. A legitimate drag originates from data.teamMembers, so the previous member?.showOnDispatch already preserved it. The new fallback only affects unknown users and fabricates an activated FIELD_CREW member. Keep unknown membership false and fix the actual hydration path by carrying explicit draft membership metadata. Add a behavioral test covering known opted-in, missing, opted-out, and FINANCE users.

  2. The selected-day copy fix is incomplete. DispatchView.tsx:435, DispatchView.tsx:481, and DispatchJobCard.tsx:111 still say “today” while viewing another day. Make all visible and accessibility copy day-neutral or selected-day-aware.

  3. dispatch-roster.test.ts:5 does not pin the regression set: it iterates the production constant itself, so deleting MANAGER or ADMIN from that constant still passes. Assert the exact expected tuple independently.

VERDICT: REQUEST_CHANGES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant