test: make time clock QA phase-aware - #418
Open
Clarion1631 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
e2e/qa-timeclock-expenses.spec.ts:24.Status: Clocked In, a three-second active interval, successful clock-out PUT, andStatus: Clocked Out.afterEach, including after assertion failures after clock-in.Why the test was wrong
The phase-only feature is correct. Its UI deliberately disables Clock In until a phase is selected. The old W4.2 test at
e2e/qa-timeclock-expenses.spec.ts:24selected only a project and clicked that disabled button. It timed out rather than exercising clock-in.Verification
npx eslint e2e/qa-timeclock-expenses.spec.ts— PASSgit diff --check— PASSnpx playwright test e2e/qa-timeclock-expenses.spec.ts --project=chromium— 9 passed (41.3s)TimeEntrycount stayed 2 before and after.Independent review
REVIEW: VERDICT: SHIP
Verdict artifact:
C:\Users\jat00\AppData\Local\Temp\t_d9e260ce-review-verdict.md