Skip to content

test: make time clock QA phase-aware - #418

Open
Clarion1631 wants to merge 2 commits into
mainfrom
geordi/t_d9e260ce
Open

test: make time clock QA phase-aware#418
Clarion1631 wants to merge 2 commits into
mainfrom
geordi/t_d9e260ce

Conversation

@Clarion1631

@Clarion1631 Clarion1631 commented Aug 29, 2026

Copy link
Copy Markdown
Owner

What changed

  • Repaired W4.2 at e2e/qa-timeclock-expenses.spec.ts:24.
  • The test now selects the seeded project, waits for its phase control, selects its loaded phase, and only then clicks Clock In.
  • It proves a successful exact-path clock-in POST, Status: Clocked In, a three-second active interval, successful clock-out PUT, and Status: Clocked Out.
  • It captures the created exact time-entry ID and deletes only that test record in afterEach, including after assertion failures after clock-in.

Why the test was wrong

The phase-only feature is correct. Its UI deliberately disables Clock In until a phase is selected. The old W4.2 test at e2e/qa-timeclock-expenses.spec.ts:24 selected only a project and clicked that disabled button. It timed out rather than exercising clock-in.

Verification

  • npx eslint e2e/qa-timeclock-expenses.spec.ts — PASS
  • git diff --check — PASS
  • Isolated local PostgreSQL Docker E2E: npx playwright test e2e/qa-timeclock-expenses.spec.ts --project=chromium — 9 passed (41.3s)
  • Exact W4.2 cleanup proof: 6 passed (26.8s); TimeEntry count stayed 2 before and after.
  • GitHub required checks for this commit: Migrations, Build + Bundle Size, Playwright E2E Tests, and Vercel — SUCCESS.

Independent review

REVIEW: VERDICT: SHIP
Verdict artifact: C:\Users\jat00\AppData\Local\Temp\t_d9e260ce-review-verdict.md

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
probuild Ready Ready Preview Aug 29, 2026 5:39am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant