Fix game version warning

[originalfoo]

Fixes #1309
Fixes #697

Game version warning message was "inverted" (eg. if game too old it was saying TM:PE too old, and vice versa).

New message looks like this - title changes depending on what is too old, but message stays same.

Additionally the auto-resume feature added by Paradox Launcher will be cancelled if compatibility issues (either game version or mod compatibility checker) are found.

[krzychu124]

Looks good 👍

[originalfoo]

659e59d : The launcher "Resume" feature will now be halted if there is a game version or mod compatibility issue, ensuring the user stays at main menu where the dialog/panel is shown.

Log contains this if the 'resume halt' is used:

Halting game 'Resume' feature due to incompatibility issue.

[originalfoo]

ready for review/merge :)

[krzychu124]

Hmmm it looks like it does not work for me 🤔 I saw dialog for half second and loading started...

[originalfoo]

Urg, maybe they changed something - or the checks are kicking in too late in the lifecycle?

[krzychu124]

It's triggered in LoadIntroComplete (m_introLoaded event) so a bit too late

Error 14.9722435: TM:PE 11.6.3 TEST is designed for Cities: Skylines 1.14.0-f4. However you are using Cities: Skylines 1.13.3-f9 - this is likely to cause severe problems or crashes.

Please ensure you're using the right version of TM:PE for this version of Cities: Skylines before proceeding, or disable TM:PE until the problem is resolved. If you need help, contact us via Steam Workshop page or Discord chat.
   at CSUtil.Commons.Log.LogToFile(System.String log, LogLevel level)
   at CSUtil.Commons.Log.Error(System.String s)
   at TrafficManager.Util.VersionUtil.CheckGameVersion()
   at TrafficManager.Lifecycle.TMPELifecycle.CompatibilityCheck()
   at LoadingManager+<LoadIntroComplete>c__Iterator8.MoveNext()
   at LoadingManager.FpsBoosterUpdate()
   at BehaviourUpdater.Updater.Update()

[originalfoo]

Here, specifically:

[originalfoo]

Oh, wait, I know what I did wrong...

I need to grab tbe value early, set it false, then if checks pass with no problems set it true and continue.

1 sec, will update code...

[krzychu124]

Oh, wait, I know what I did wrong...

I need to grab tbe value early, set it false, then if checks pass with no problems set it true and continue.

1 sec, will update code...

I was about to say that, since user can't make any decision if continue or not...

[originalfoo]

Stopping it in TMPELifecycle.StartMod(); should be early enough, yes?

[krzychu124]

Stopping it in TMPELifecycle.StartMod(); should be early enough, yes?

Hehe, you can't do that earlier (that method is called in OnEnabled)

[originalfoo]

Constructor of TrafficManagerMod or is that still too late?

[krzychu124]

Constructor of TrafficManagerMod or is that still too late?

.ctor is called right before OnEnabled so either this or that. In any means looking at detailed log of initialization of game components both are good enough spots

[originalfoo]

ok, try that :)

[krzychu124]

Hehe, I thought you will check for incompatibilities and disable if necessary then wait to show dialog with warning 😄

Anyways, feature is working as it should. Merging...

[originalfoo]

I can't check incompatibilities of mods reliably at that stage (tried that back in #699 )