Addition of service graph modules and their test files (DCNE-410) #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
…h_template_node module
github-actions
bot
changed the title
…tion_interface_context module
akinross
requested changes
May 7, 2025
plugins/modules/aci_l4l7_service_graph_template_abs_connection.py
Outdated
Show resolved
Hide resolved
…ervice_graph_template modules
samiib
requested changes
May 9, 2025
| - cisco.aci.annotation | ||
|
|
||
| notes: | ||
| - The I(tenant), I(graph), I(contract) and I(node) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Suggested change
| - The I(tenant), I(graph), I(contract) and I(node) must exist before using this module in your playbook. | |
| - The O(tenant), O(graph), O(contract) and O(node) must exist before using this module in your playbook. |
There was a problem hiding this comment.
This comment was already made by @gmicol in a related PR. In ansible ACI collection we've been using I() for Input in the other modules. I believe that this usage should be consistent within this collection.
| type: str | ||
| permit_handoff: | ||
| description: | ||
| - Indicates whether to allow handoff of traffic to the associated logical interface. |
There was a problem hiding this comment.
Does APIC default these Booleans to anything when unset? permit_handoff, acl, rule_type?
Comment on lines
+387
to
+396
| # child_configs.append( | ||
| # { | ||
| # "vnsRsLIfCtxToBD": { | ||
| # "attributes": { | ||
| # "dn": child.get("vnsRsLIfCtxToBD").get("attributes").get("dn"), | ||
| # "status": "deleted", | ||
| # } | ||
| # } | ||
| # } | ||
| # ) |
There was a problem hiding this comment.
Suggested change
| # child_configs.append( | |
| # { | |
| # "vnsRsLIfCtxToBD": { | |
| # "attributes": { | |
| # "dn": child.get("vnsRsLIfCtxToBD").get("attributes").get("dn"), | |
| # "status": "deleted", | |
| # } | |
| # } | |
| # } | |
| # ) |
Not sure if you need the previous code. I think the comment is fine.
There was a problem hiding this comment.
We left the code commented in other modules as well. I left it to be consistent with them..
| - cisco.aci.aci | ||
| - cisco.aci.annotation | ||
| notes: | ||
| - The I(tenant), I(contract), I(graph), I(device) and I(node) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Suggested change
| - The I(tenant), I(contract), I(graph), I(device) and I(node) must exist before using this module in your playbook. | |
| - The O(tenant), O(contract), O(graph), O(device) and O(node) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Same comment as above
| - cisco.aci.annotation | ||
| - cisco.aci.owner | ||
| notes: | ||
| - The I(tenant) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Suggested change
| - The I(tenant) must exist before using this module in your playbook. | |
| - The O(tenant) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Same comment as above
| choices: [ redirect, unspecified ] | ||
| is_copy: | ||
| description: | ||
| - Whether the device is a copy device. |
| type: bool | ||
| share_encap: | ||
| description: | ||
| - Whether to share encapsulation across the service graph. |
| - cisco.aci.annotation | ||
| - cisco.aci.owner | ||
| notes: | ||
| - The I(tenant), I(service_graph) and I(device) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Suggested change
| - The I(tenant), I(service_graph) and I(device) must exist before using this module in your playbook. | |
| - The O(tenant), O(service_graph) and O(device) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Same comment as above
| - cisco.aci.annotation | ||
| - cisco.aci.owner | ||
| notes: | ||
| - The I(tenant) and I(service_graph) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Suggested change
| - The I(tenant) and I(service_graph) must exist before using this module in your playbook. | |
| - The O(tenant) and O(service_graph) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Same comment as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.