refactor:converted sequential.ts to TypeScript

[akshitvigg]

Fixes #661

Describe the changes you have made in this PR -

Converted sequential.js to TypeScript while maintaining the logic and functionality same

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

---

• Refactor

  • Enhanced the sequential module with improved TypeScript type safety. Added explicit type annotations for the changeClockEnable function parameter and return type. Implemented boolean type for the clock enable value parameter, ensuring type-safe assignment to simulation area properties. These improvements increase code reliability and enable better IDE support and error detection throughout the development process.

Summary by CodeRabbit

• Refactor
  • Enhanced type safety through improved function type annotations in the simulator module.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[netlify]

✅ Deploy Preview for circuitverse ready!

Name	Link
🔨 Latest commit	a1da110
🔍 Latest deploy log	https://app.netlify.com/projects/circuitverse/deploys/692ddbf0fe64e4000830c463
😎 Deploy Preview	https://deploy-preview-682--circuitverse.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 44 (no change from production) Accessibility: 73 (no change from production) Best Practices: 92 (no change from production) SEO: 82 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Walkthrough

This PR adds explicit TypeScript type annotations to the changeClockEnable function in sequential.ts. The parameter val is typed as boolean and the return type is declared as void. The underlying logic remains unchanged.

Changes

Cohort / File(s)	Summary
TypeScript type annotations src/simulator/src/sequential.ts	Added explicit type annotations to exported function changeClockEnable: parameter val typed as boolean and return type declared as void. Logic unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file change with straightforward type annotation addition
• No logic modifications or behavioral changes
• Mechanical TypeScript conversion task

Suggested reviewers

• JoshVarga

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: converting sequential.ts to TypeScript with proper type annotations.
Linked Issues check	✅ Passed	The PR successfully converts sequential.js to TypeScript by adding explicit type annotations to exported functions while maintaining existing logic, directly addressing issue #661 requirements.
Out of Scope Changes check	✅ Passed	All changes are scoped to converting sequential.ts to TypeScript with type annotations; no unrelated modifications or logic changes are present.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11b4883 and a1da110.

📒 Files selected for processing (1)

• src/simulator/src/sequential.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-24T05:25:39.773Z

Learnt from: 092vk
Repo: CircuitVerse/cv-frontend-vue PR: 644
File: src/simulator/src/utils.ts:54-61
Timestamp: 2025-08-24T05:25:39.773Z
Learning: In CircuitVerse simulator, clearing the clock interval (simulationArea.ClockInterval) during pause can cause unexpected results. The safer approach is to let the clock continue ticking and use flag checks in clockTick() to prevent simulation updates.

Applied to files:

• src/simulator/src/sequential.ts

🔇 Additional comments (1)

src/simulator/src/sequential.ts (1)

8-9: Type annotation looks correct; just confirm all callers pass booleans

val: boolean and the explicit void return type align with the semantics of simulationArea.clockEnabled and keep runtime behavior unchanged. Please just verify that all existing changeClockEnable call sites already pass true/false (and not 0/1 or stringy flags), so this remains a pure typing improvement without forcing casts or type loosening later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}