Correct description of "En" output for Priority Encoder #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "En" port was described as an input to the priority encoder, when really it is an output that indicates whether the input is not all zero (and hence the outputs Tn are not meaningful).
The circuit shown in the iframe also needs to be updated, but I cannot do that. Right now, it connects an input to the En port, which triggers a contention error.
Ref CircuitVerse#1718: This issue was spotted quite a while ago, but the proposed fix changed the name of the output port, and was rejected. This change merely documents the status quo, which I think is necessary - multiple students of mine were confused by the documentation!
Changes done:
Screenshots:
Not applicable.
Preview Link(s):
https://github.com/TobiasKappe/CircuitVerseDocs/blob/897f909b1fef934241372fcca955d089a848846d/docs/chapter4/5muxandplex.md#priority-encoder
✅️ By submitting this PR, I have verified the following