Skip to content

Conversation

shubham-021
Copy link

@shubham-021 shubham-021 commented Jul 30, 2025

Fixes #5921

Describe the changes you have made in this PR -

Application was facing this issue : PG::QueryCanceled: ERROR: canceling statement due to statement timeout

This issue was coming from CircuitVerse/app/controllers/projects_controller.rb line 31 that is
"if current_visit && !Ahoy::Event.exists?(visit_id: current_visit.id, name: "Visited project #{@project.id}")"

The query was slow because the ahoy_events table was missing an index on the combination of visit_id and name , which led PostgreSQL to scan the entire database resulting in timeout.

I added a database index on the ahoy_events table for the columns visit_id and name, using a non-blocking migration which improves query performance

Screenshots of the UI changes (If any) -

Checklist before requesting a review

  • I have added proper PR title and linked to the issue
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Summary by CodeRabbit

  • Chores
    • Improved database performance by adding a new index to the ahoy_events table for the visit_id and name columns.

Copy link

coderabbitai bot commented Jul 30, 2025

Walkthrough

A new Rails migration is introduced to add a concurrent composite index on the visit_id and name columns of the ahoy_events table. The schema file is updated to reflect this new index and the latest schema version. No other changes are present.

Changes

Cohort / File(s) Change Summary
Migration: Add composite index
db/migrate/20250730084559_add_index_to_ahoy_events_on_visit_id_and_name.rb
Adds a migration to create a concurrent index on ahoy_events(visit_id, name); disables DDL transaction wrapping.
Schema update
db/schema.rb
Updates schema version and adds the new composite index on ahoy_events.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective Addressed Explanation
Add a concurrent composite index on ahoy_events(visit_id, name) to address query timeouts (#5921)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related issues

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4662ff9 and f0e01f7.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • db/migrate/20250730084559_add_index_to_ahoy_events_on_visit_id_and_name.rb (1 hunks)
  • db/schema.rb (2 hunks)
🔇 Additional comments (3)
db/migrate/20250730084559_add_index_to_ahoy_events_on_visit_id_and_name.rb (1)

1-7: Excellent migration implementation!

This migration correctly addresses the query timeout issue by:

  • Using disable_ddl_transaction! to allow concurrent index creation
  • Adding a composite index on [:visit_id, :name] that matches the problematic query pattern
  • Using algorithm: :concurrently to prevent table locks during deployment

The column order is optimal since visit_id is the primary filter in the original query.

db/schema.rb (2)

13-13: Schema version updated correctly.

The version timestamp matches the migration file and follows Rails conventions.


53-53: Index added correctly to schema.

The composite index index_ahoy_events_on_visit_id_and_name is properly defined and positioned within the ahoy_events table. This will significantly improve the performance of the query that was causing timeouts.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveRecord::QueryCanceled: [safely] PG::QueryCanceled: ERROR: canceling statement due to statement timeout (ActiveRecord::QueryCanceled)
1 participant