Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the method and variable naming for clarity when retrieving Response request info #41

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

apotek
Copy link
Contributor

@apotek apotek commented Oct 15, 2024

Description

Having a method named getRequest() seemed confusing as it would seem to indicate returning a request object or state as opposed to simply the request path.

This merge request fixes this for clarity.

@apotek apotek requested a review from mmatsoo October 15, 2024 22:22
@apotek apotek self-assigned this Oct 15, 2024
@apotek apotek merged commit 8d8fe40 into 2.x Oct 16, 2024
4 checks passed
@apotek apotek deleted the improve-response-request-method-naming branch October 16, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a means for implementors to be able to access the final API request made
1 participant