Capture the request data to the response to enable logging and troubleshooting #40
Conversation
|
The failing tests are not trivial to fix. Will take some work. |
| @@ -128,7 +126,7 @@ public function request( | |||
|
|
|||
| try { | |||
| // Make a request with given parameters. | |||
| return new Response($this->client->request($method, $url, $options)); | |||
| return new Response($this->httpClient, $method, $url, $options); | |||
There was a problem hiding this comment.
@apotek Just checking if ->request() was accidentally left off. I see the original has it.
There was a problem hiding this comment.
@apotek Just checking if
->request()was accidentally left off. I see the original has it.
You are right to ask about this. This change set changes the constructor of the Response class to no longer accept a GuzzleResponse (which is what client->request() would return), but instead accepts the request client object, and the request parameters:
This allows the constructor function in the Response object to save some data to itself about the request that is about to be made, so that the Response can be queried for data about the request that created that response.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
apotek
deleted the
39-provide-a-means-for-implementors-to-be-able-to-access-the-final-api-request-made
branch
Description
In this merge request we add the API request data to our custom response object so that any caller who receives a response will be able to see the exact request data that produced the response. This can be helpful for diagnostics and troubleshooting,.
Motivation / Context
Greater insight into what the API is doing.
Resolves #39
Testing Instructions / How This Has Been Tested
Documentation