Skip to content

Commit

Permalink
Studio/track finder: find text is a list of strings. Re 3155.
Browse files Browse the repository at this point in the history
Find text list is strictly a list of strings. Although None or an empty string might be inserted somehow, as far as semantics is concerned, it is a list of strings. This resolves type mismatch reported by Mypy when describing find next/previous commands. List filtering will remain to catch None and empty strings.
  • Loading branch information
josephsl committed Jan 26, 2021
1 parent ae8a0c4 commit fea9fe4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion addon/appModules/splstudio/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1385,7 +1385,7 @@ def script_setBrailleTimer(self, gesture):
# This new function will be used by track finder and place marker locator.
# 17.08: now it is a list that records search history.
# 21.03: accept both None and str because it will be filtered to remove None anyway.
findText: Optional[list[Optional[str]]] = None
findText: Optional[list[str]] = None

def trackFinder(
self, text: str, obj: Any, directionForward: bool = True, column: Optional[list[int]] = None
Expand Down

0 comments on commit fea9fe4

Please sign in to comment.