-
Notifications
You must be signed in to change notification settings - Fork 0
Fix blank frontend mount and add foundational UI styling #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import React from 'react'; | ||
| import { createRoot } from 'react-dom/client'; | ||
| import App from './app'; | ||
| import './styles.css'; | ||
|
|
||
| createRoot(document.getElementById('root')!).render( | ||
| <React.StrictMode> | ||
| <App /> | ||
| </React.StrictMode> | ||
| ); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| @tailwind base; | ||
| @tailwind components; | ||
| @tailwind utilities; | ||
|
|
||
| :root { | ||
| color-scheme: dark; | ||
| } | ||
|
|
||
| body { | ||
| @apply min-h-screen bg-slate-950 text-slate-100 antialiased; | ||
| margin: 0; | ||
| font-family: Inter, system-ui, -apple-system, Segoe UI, Roboto, Helvetica, Arial, sans-serif; | ||
| } | ||
|
|
||
| * { | ||
| scrollbar-width: thin; | ||
| scrollbar-color: rgb(51 65 85) rgb(15 23 42); | ||
|
Comment on lines
+15
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Consider scoping the global scrollbar styles more narrowly than the universal Applying these scrollbar styles via html {
scrollbar-width: thin;
scrollbar-color: rgb(51 65 85) rgb(15 23 42);
}Suggested implementation: I don't see the
|
||
| } | ||
|
|
||
| ::-webkit-scrollbar { | ||
| width: 10px; | ||
| height: 10px; | ||
| } | ||
|
|
||
| ::-webkit-scrollbar-track { | ||
| background: rgb(15 23 42); | ||
| } | ||
|
|
||
| ::-webkit-scrollbar-thumb { | ||
| background: rgb(51 65 85); | ||
| border-radius: 9999px; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.htmlnow boots the app frommain.tsx, buttsconfig.jsonstill limitsincludetoapp.tsxandsrc, sonpm run build'stscstep does not type-check this new bootstrap file. That creates a blind spot where entrypoint regressions (e.g., bad imports or mount logic changes) can ship even though the type-check step passes. Please addmain.tsx(or broaden the include pattern) so CI validates the actual runtime entrypoint.Useful? React with 👍 / 👎.