Skip to content

Handle unsupported ID3 frames in MP3 Quick Cleanse (remove TENC, add safeSetFrame) #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisAdamsdevelopment merged 1 commit into from
May 18, 2026
Merged

Handle unsupported ID3 frames in MP3 Quick Cleanse (remove TENC, add safeSetFrame) #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/utils/metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,20 @@ export async function writeMP3Metadata(file, metadata) {
const artist = safeText(metadata?.artist);
const genre = safeText(metadata?.genre);

const safeSetFrame = (frameId, value) => {
try {
writer.setFrame(frameId, value);
return true;
} catch (error) {
console.warn('[quick-cleanse] skipped unsupported ID3 frame', { frameId, error });
return false;
}
};

try {
if (title) writer.setFrame('TIT2', title);
if (artist) writer.setFrame('TPE1', [artist]);
if (genre) writer.setFrame('TCON', [genre]);
if (title || artist || genre) writer.setFrame('TENC', 'SpectraCleanseAI Browser Quick Cleanse');
if (title) safeSetFrame('TIT2', title);
if (artist) safeSetFrame('TPE1', [artist]);
if (genre) safeSetFrame('TCON', [genre]);
writer.addTag();
} catch (error) {
throw new Error(`Failed while writing ID3 frames: ${error?.message || String(error)}`);
Expand Down
Loading