Skip to content

Fix music-metadata-browser import resolution and lazy-load parser for build stability #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisAdamsdevelopment merged 1 commit into from
May 4, 2026
Merged

Fix music-metadata-browser import resolution and lazy-load parser for build stability #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/utils/metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,22 @@
import { parseBlob } from 'music-metadata-browser';
import ID3Writer from 'browser-id3-writer';

const AI_MARKERS = ['ai','generated','suno','udio','boomy','aiva','soundraw','mubert','stable audio','provenance','c2pa','content credentials','watermark','synthetic','elevenlabs'];
const MARKER_REGEX_CACHE = new Map();

let parseBlobLoader = null;

async function getParseBlob() {
if (parseBlobLoader) return parseBlobLoader;
parseBlobLoader = import('music-metadata-browser').then((mod) => {
Comment on lines +9 to +10
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear cached loader when dynamic import rejects

If import('music-metadata-browser') fails once (for example a transient chunk/network load error), parseBlobLoader is left pointing at a rejected promise and every later readFileMetadata() call will immediately fail in the same session, even after conditions recover. This regresses resilience because the code never retries module resolution unless the page is reloaded; resetting the cache on rejection would allow a subsequent attempt to succeed.

Useful? React with 👍 / 👎.

const fn = mod?.parseBlob || mod?.default?.parseBlob;
if (typeof fn !== 'function') {
throw new Error('music-metadata-browser parseBlob export not found');
}
return fn;
});
return parseBlobLoader;
}

function escapeRegex(value) {
return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
}
Expand All @@ -18,7 +31,7 @@ function markerToRegex(marker) {
return regex;
}

function collectStrings(metadata) {
function collectStrings(metadata, fileName = '') {
const common = metadata?.common || {};
const native = metadata?.native || {};
const values = [common.title,common.artist,common.album,...(common.genre || []),...(common.comment || []),common.encodedby,common.publisher]
Expand All @@ -31,6 +44,7 @@ function collectStrings(metadata) {
if (frame?.value && typeof frame.value === 'object') values.push(JSON.stringify(frame.value));
});
});
if (fileName) values.push(String(fileName));
return values.join(' | ').toLowerCase();
}

Expand All @@ -39,12 +53,13 @@ export async function readFileMetadata(file) {
let parseError = null;

try {
const parseBlob = await getParseBlob();
parsed = await parseBlob(file);
} catch (error) {
parseError = error;
}

const searchable = collectStrings(parsed);
const searchable = collectStrings(parsed, file?.name || '');
const detectedMarkers = AI_MARKERS.filter((marker) => markerToRegex(marker).test(searchable));
return {
format: parsed?.format?.container || file.type || 'unknown',
Expand Down