Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyboardFix for 1.16 and 1.17 #1019

Open
wants to merge 1 commit into
base: llama
Choose a base branch
from

Conversation

XXMA16
Copy link

@XXMA16 XXMA16 commented Mar 28, 2023

As far as I tested this is not an issue, but I am unsure whether or not it will prove to be one in the future.

Jinxed it

Both Lambdas (being method_1458 and method_1473) have different Optifine signatures in 1.16 and 1.17 meaning the JVM will hava a stroke when it looks for a bootstrap method with the signature (Lnet/minecraft/class_309;IILnet/minecraft/class_364;)V and doesn't find it. Since JEI doesn't exist for any version lower than 1.18.2 not patching these lambdas (or outright replacing them with the vanilla ones) should not break anything that wasn't broken before. Just to make sure, I tested the following versions and the game does properly work:

  • 1.16.5
  • 1.18.2 (with JEI)
  • 1.19.2 (with JEI)

fixed #1013
Thank you @akemin-dayo for the detailed reports!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant