Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinxed it
Both Lambdas (being
method_1458
andmethod_1473
) have different Optifine signatures in 1.16 and 1.17 meaning the JVM will hava a stroke when it looks for a bootstrap method with the signature(Lnet/minecraft/class_309;IILnet/minecraft/class_364;)V
and doesn't find it. Since JEI doesn't exist for any version lower than 1.18.2 not patching these lambdas (or outright replacing them with the vanilla ones) should not break anything that wasn't broken before. Just to make sure, I tested the following versions and the game does properly work:fixed #1013
Thank you @akemin-dayo for the detailed reports!