Fix ParentRequires not working with EF Core projections #8749
+176
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
ParentRequires
functionality was not working when using EF Core projections. Required parent properties were not being included in the generated EF Core queries, causing computed properties to incorrectly resolvers if parent data wasn't also referenced in the query.Problem
The
ParentRequires
feature worked correctly with the built-inSelectionExpressionBuilder
but failed when using EF Core projections throughUseProjection()
. This happened because:SelectionExpressionBuilder
processes field requirements and includes them in projectionsQueryableProjectionVisitor
(used by EF Core projections) did not have any logic to handle field requirementsSolution
Added field requirements processing to
QueryableProjectionVisitor
following the same pattern asSelectionExpressionBuilder
Changes Made
Core Implementation
QueryableProjectionVisitor.cs
: added requirements processing logic following SelectionExpressionBuilder patternsTests
IntegrationTests.cs
: added tests for both string-based and expression-based ParentRequires scenarios